Skip to content

Commit

Permalink
hw/ppc/spapr: use qemu_get_nic_info() and pci_init_nic_devices()
Browse files Browse the repository at this point in the history
Avoid directly referencing nd_table[] by first instantiating any
spapr-vlan devices using a qemu_get_nic_info() loop, then calling
pci_init_nic_devices() to do the rest.

No functional change intended.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
dwmw2 committed Feb 2, 2024
1 parent 4c71721 commit 0aff816
Showing 1 changed file with 5 additions and 13 deletions.
18 changes: 5 additions & 13 deletions hw/ppc/spapr.c
Original file line number Diff line number Diff line change
Expand Up @@ -2796,6 +2796,7 @@ static void spapr_machine_init(MachineState *machine)
MemoryRegion *sysmem = get_system_memory();
long load_limit, fw_size;
Error *resize_hpt_err = NULL;
NICInfo *nd;

if (!filename) {
error_report("Could not find LPAR firmware '%s'", bios_name);
Expand Down Expand Up @@ -2996,21 +2997,12 @@ static void spapr_machine_init(MachineState *machine)

phb = spapr_create_default_phb();

for (i = 0; i < nb_nics; i++) {
NICInfo *nd = &nd_table[i];

if (!nd->model) {
nd->model = g_strdup("spapr-vlan");
}

if (g_str_equal(nd->model, "spapr-vlan") ||
g_str_equal(nd->model, "ibmveth")) {
spapr_vlan_create(spapr->vio_bus, nd);
} else {
pci_nic_init_nofail(&nd_table[i], phb->bus, nd->model, NULL);
}
while ((nd = qemu_find_nic_info("spapr-vlan", true, "ibmveth"))) {
spapr_vlan_create(spapr->vio_bus, nd);
}

pci_init_nic_devices(phb->bus, NULL);

for (i = 0; i <= drive_get_max_bus(IF_SCSI); i++) {
spapr_vscsi_create(spapr->vio_bus);
}
Expand Down

0 comments on commit 0aff816

Please sign in to comment.