Skip to content

Commit

Permalink
tests/qapi-schema: Cover 'Features:' not followed by descriptions
Browse files Browse the repository at this point in the history
A 'Features:' line without any features is useless, but not an error
now.  However, a later commit will make it one, because that makes
rejecting duplicate 'Features:' easier.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240216145841.2099240-4-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
  • Loading branch information
Markus Armbruster committed Feb 26, 2024
1 parent fc68b9f commit 0ba2915
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 0 deletions.
Empty file.
10 changes: 10 additions & 0 deletions tests/qapi-schema/doc-empty-features.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# 'Features:' line not followed by feature descriptions

##
# @foo:
#
# Features:
#
# not a description
##
{ 'command': 'foo' }
19 changes: 19 additions & 0 deletions tests/qapi-schema/doc-empty-features.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module ./builtin
object q_empty
enum QType
prefix QTYPE
member none
member qnull
member qnum
member qstring
member qdict
member qlist
member qbool
module doc-empty-features.json
command foo None -> None
gen=True success_response=True boxed=False oob=False preconfig=False
doc symbol=foo
body=

section=None
not a description
1 change: 1 addition & 0 deletions tests/qapi-schema/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ schemas = [
'doc-duplicated-return.json',
'doc-duplicated-since.json',
'doc-empty-arg.json',
'doc-empty-features.json',
'doc-empty-section.json',
'doc-empty-symbol.json',
'doc-good.json',
Expand Down

0 comments on commit 0ba2915

Please sign in to comment.