Skip to content

Commit

Permalink
tests/aio: Clean up global variable shadowing
Browse files Browse the repository at this point in the history
Rename the argument to fix:

  tests/unit/test-aio.c:130:44: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
  static void set_event_notifier(AioContext *ctx, EventNotifier *notifier,
                                             ^
  tests/unit/test-aio.c:22:20: note: previous declaration is here
  static AioContext *ctx;
                     ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231009100251.56019-9-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
philmd authored and huth committed Oct 27, 2023
1 parent ec3ad0f commit 0c2c293
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/unit/test-aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ static void *test_acquire_thread(void *opaque)
return NULL;
}

static void set_event_notifier(AioContext *ctx, EventNotifier *notifier,
static void set_event_notifier(AioContext *nctx, EventNotifier *notifier,
EventNotifierHandler *handler)
{
aio_set_event_notifier(ctx, notifier, handler, NULL, NULL);
aio_set_event_notifier(nctx, notifier, handler, NULL, NULL);
}

static void dummy_notifier_read(EventNotifier *n)
Expand Down

0 comments on commit 0c2c293

Please sign in to comment.