Skip to content

Commit

Permalink
s390: avoid reaching into memory core internals
Browse files Browse the repository at this point in the history
use cpu_physical_memory_is_io() instead.

Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
avikivity committed Oct 22, 2012
1 parent f6790af commit 0e8a6d4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions target-s390x/misc_helper.c
Expand Up @@ -20,7 +20,6 @@

#include "cpu.h"
#include "memory.h"
#include "cputlb.h"
#include "host-utils.h"
#include "helper.h"
#include <string.h>
Expand Down Expand Up @@ -81,7 +80,7 @@ int sclp_service_call(CPUS390XState *env, uint32_t sccb, uint64_t code)
#endif

/* basic checks */
if (!memory_region_is_ram(phys_page_find(sccb >> TARGET_PAGE_BITS)->mr)) {
if (cpu_physical_memory_is_io(sccb)) {
return -PGM_ADDRESSING;
}
if (sccb & ~0x7ffffff8ul) {
Expand Down

0 comments on commit 0e8a6d4

Please sign in to comment.