Skip to content

Commit

Permalink
tests: skip dbus-display tests that need a console
Browse files Browse the repository at this point in the history
When compiling with "configure --without-default-devices", the
dbus-display-test fails since it implicitly assumes that the
machine comes with a default console.

There doesn't seem to be an easy way to figure this during build time,
so skip the tests requiring the Console interface at runtime.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20240221073759.171443-1-marcandre.lureau@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
elmarco authored and huth committed Feb 23, 2024
1 parent 1172428 commit 0e9a891
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions tests/qtest/dbus-display-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ test_dbus_console_registered(GObject *source_object,
NULL,
#endif
res, &err);

if (g_error_matches(err, G_DBUS_ERROR, G_DBUS_ERROR_UNKNOWN_METHOD)) {
g_test_skip("The VM doesn't have a console!");
g_main_loop_quit(test->loop);
return;
}

g_assert_no_error(err);

test->listener_conn = g_thread_join(test->thread);
Expand All @@ -156,7 +163,7 @@ test_dbus_display_console(void)
g_autoptr(GMainLoop) loop = NULL;
QTestState *qts = NULL;
int pair[2];
TestDBusConsoleRegister test;
TestDBusConsoleRegister test = { 0, };
#ifdef WIN32
WSAPROTOCOL_INFOW info;
g_autoptr(GVariant) listener = NULL;
Expand Down Expand Up @@ -245,7 +252,6 @@ test_dbus_display_keyboard(void)
&err));
g_assert_no_error(err);


g_assert_cmpint(qtest_inb(qts, 0x64) & 0x1, ==, 0);
g_assert_cmpint(qtest_inb(qts, 0x60), ==, 0);

Expand All @@ -256,6 +262,12 @@ test_dbus_display_keyboard(void)
-1,
NULL,
&err);
if (g_error_matches(err, G_DBUS_ERROR, G_DBUS_ERROR_UNKNOWN_METHOD)) {
g_test_skip("The VM doesn't have a console!");
qtest_quit(qts);
return;
}

g_assert_no_error(err);

/* may be should wait for interrupt? */
Expand Down

0 comments on commit 0e9a891

Please sign in to comment.