Skip to content

Commit

Permalink
i386/pc: handle unitialized mr in pc_get_cxl_range_end()
Browse files Browse the repository at this point in the history
Remove pc_get_cxl_range_end() dependency on the CXL memory region,
and replace with one that does not require the CXL host_mr to determine
the start of CXL start.

This in preparation to allow pc_pci_hole64_start() to be called early
in pc_memory_init(), handle CXL memory region end when its underlying
memory region isn't yet initialized.

Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Message-Id: <20220719170014.27028-8-joao.m.martins@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>
  • Loading branch information
jpemartins authored and mstsirkin committed Jul 26, 2022
1 parent 42bed07 commit 1065b21
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions hw/i386/pc.c
Expand Up @@ -843,17 +843,15 @@ static uint64_t pc_get_cxl_range_start(PCMachineState *pcms)

static uint64_t pc_get_cxl_range_end(PCMachineState *pcms)
{
uint64_t start = 0;
uint64_t start = pc_get_cxl_range_start(pcms) + MiB;

if (pcms->cxl_devices_state.host_mr.addr) {
start = pcms->cxl_devices_state.host_mr.addr +
memory_region_size(&pcms->cxl_devices_state.host_mr);
if (pcms->cxl_devices_state.fixed_windows) {
GList *it;
for (it = pcms->cxl_devices_state.fixed_windows; it; it = it->next) {
CXLFixedWindow *fw = it->data;
start = fw->mr.addr + memory_region_size(&fw->mr);
}
if (pcms->cxl_devices_state.fixed_windows) {
GList *it;

start = ROUND_UP(start, 256 * MiB);
for (it = pcms->cxl_devices_state.fixed_windows; it; it = it->next) {
CXLFixedWindow *fw = it->data;
start += fw->size;
}
}

Expand Down

0 comments on commit 1065b21

Please sign in to comment.