Skip to content

Commit

Permalink
libcacard: Plug memory leaks around vreader_get_reader_list()
Browse files Browse the repository at this point in the history
Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
Markus Armbruster authored and Michael Tokarev committed May 23, 2014
1 parent d357e3d commit 124fe7f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions libcacard/vcard_emul_nss.c
Expand Up @@ -433,11 +433,13 @@ vcard_emul_find_vreader_from_slot(PK11SlotInfo *slot)
VReader *reader = vreader_list_get_reader(current_entry);
VReaderEmul *reader_emul = vreader_get_private(reader);
if (reader_emul->slot == slot) {
vreader_list_delete(reader_list);
return reader;
}
vreader_free(reader);
}

vreader_list_delete(reader_list);
return NULL;
}

Expand Down Expand Up @@ -1059,6 +1061,8 @@ vcard_emul_replay_insertion_events(void)
next_entry = vreader_list_get_next(current_entry);
vreader_queue_card_event(vreader);
}

vreader_list_delete(list);
}

/*
Expand Down
1 change: 1 addition & 0 deletions libcacard/vscclient.c
Expand Up @@ -570,6 +570,7 @@ do_command(GIOChannel *source,
"CARD_PRESENT" : " ",
vreader_get_name(reader));
}
vreader_list_delete(list);
} else if (*string != 0) {
printf("valid commands:\n");
printf("insert [reader_id]\n");
Expand Down

0 comments on commit 124fe7f

Please sign in to comment.