Skip to content

Commit

Permalink
hw/sparc/sun4m: Fix implicit creation of "-drive if=scsi" devices
Browse files Browse the repository at this point in the history
The global hack for creating SCSI devices has recently been removed,
but this apparently broke SCSI devices on some boards that were not
ready for this change yet. For the sun4m machines you now get:

$ sparc-softmmu/qemu-system-sparc -boot d -cdrom x.iso
qemu-system-sparc: -cdrom x.iso: machine type does not support if=scsi,bus=0,unit=2

Fix it by calling scsi_bus_legacy_handle_cmdline() after creating the
corresponding SCSI controller.

Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: 1454509
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  • Loading branch information
huth authored and mcayland committed Mar 8, 2018
1 parent f32408f commit 12850b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions hw/sparc/sun4m.c
Expand Up @@ -324,6 +324,7 @@ static void *sparc32_dma_init(hwaddr dma_base,

esp = ESP_STATE(object_resolve_path_component(OBJECT(espdma), "esp"));
sysbus_mmio_map(SYS_BUS_DEVICE(esp), 0, esp_base);
scsi_bus_legacy_handle_cmdline(&esp->esp.bus);

ledma = SPARC32_LEDMA_DEVICE(object_resolve_path_component(
OBJECT(dma), "ledma"));
Expand Down

0 comments on commit 12850b1

Please sign in to comment.