Skip to content

Commit

Permalink
tests: Use error_free_or_abort() where appropriate
Browse files Browse the repository at this point in the history
Done with this Coccinelle semantic patch:

    @@
    expression E;
    @@
    -    g_assert(E);
    -    error_free(E);
    +    error_free_or_abort(&E);

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1487362554-5688-1-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
  • Loading branch information
Markus Armbruster committed Mar 15, 2017
1 parent d84f714 commit 157db29
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions tests/test-qemu-opts.c
Expand Up @@ -93,8 +93,7 @@ static void test_find_unknown_opts(void)
/* should not return anything, we don't have an "unknown" option */
list = qemu_find_opts_err("unknown", &err);
g_assert(list == NULL);
g_assert(err);
error_free(err);
error_free_or_abort(&err);
}

static void test_qemu_find_opts(void)
Expand Down
6 changes: 2 additions & 4 deletions tests/test-qobject-output-visitor.c
Expand Up @@ -145,8 +145,7 @@ static void test_visitor_out_enum_errors(TestOutputVisitorData *data,
for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) {
err = NULL;
visit_type_EnumOne(data->ov, "unused", &bad_values[i], &err);
g_assert(err);
error_free(err);
error_free_or_abort(&err);
visitor_reset(data);
}
}
Expand Down Expand Up @@ -244,8 +243,7 @@ static void test_visitor_out_struct_errors(TestOutputVisitorData *data,
u.has_enum1 = true;
u.enum1 = bad_values[i];
visit_type_UserDefOne(data->ov, "unused", &pu, &err);
g_assert(err);
error_free(err);
error_free_or_abort(&err);
visitor_reset(data);
}
}
Expand Down

0 comments on commit 157db29

Please sign in to comment.