Skip to content

Commit

Permalink
bsd-user: Tidy VERIFY_READ/VERIFY_WRITE
Browse files Browse the repository at this point in the history
These constants are only ever used with access_ok, and friends.
Rather than translating them to PAGE_* bits, let them equal
the PAGE_* bits to begin.

Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20210212184902.1251044-9-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
rth7680 authored and pm215 committed Feb 16, 2021
1 parent 68f7766 commit 1720751
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions bsd-user/qemu.h
Expand Up @@ -218,13 +218,12 @@ extern unsigned long x86_stack_size;

/* user access */

#define VERIFY_READ 0
#define VERIFY_WRITE 1 /* implies read access */
#define VERIFY_READ PAGE_READ
#define VERIFY_WRITE (PAGE_READ | PAGE_WRITE)

static inline int access_ok(int type, abi_ulong addr, abi_ulong size)
static inline bool access_ok(int type, abi_ulong addr, abi_ulong size)
{
return page_check_range((target_ulong)addr, size,
(type == VERIFY_READ) ? PAGE_READ : (PAGE_READ | PAGE_WRITE)) == 0;
return page_check_range((target_ulong)addr, size, type) == 0;
}

/* NOTE __get_user and __put_user use host pointers and don't check access. */
Expand Down

0 comments on commit 1720751

Please sign in to comment.