Skip to content

Commit

Permalink
socket: Make errp the last parameter of vsock_connect_saddr
Browse files Browse the repository at this point in the history
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20170421122710.15373-5-famz@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
  • Loading branch information
Fam Zheng authored and Markus Armbruster committed Apr 24, 2017
1 parent 2bdc679 commit 1a9a7f2
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions util/qemu-sockets.c
Expand Up @@ -728,9 +728,10 @@ static int vsock_connect_addr(const struct sockaddr_vm *svm, bool *in_progress,
return sock;
}

static int vsock_connect_saddr(VsockSocketAddress *vaddr, Error **errp,
static int vsock_connect_saddr(VsockSocketAddress *vaddr,
NonBlockingConnectHandler *callback,
void *opaque)
void *opaque,
Error **errp)
{
struct sockaddr_vm svm;
int sock = -1;
Expand Down Expand Up @@ -819,9 +820,9 @@ static void vsock_unsupported(Error **errp)
error_setg(errp, "socket family AF_VSOCK unsupported");
}

static int vsock_connect_saddr(VsockSocketAddress *vaddr, Error **errp,
static int vsock_connect_saddr(VsockSocketAddress *vaddr,
NonBlockingConnectHandler *callback,
void *opaque)
void *opaque, Error **errp)
{
vsock_unsupported(errp);
return -1;
Expand Down Expand Up @@ -1100,7 +1101,7 @@ int socket_connect(SocketAddress *addr, NonBlockingConnectHandler *callback,
break;

case SOCKET_ADDRESS_KIND_VSOCK:
fd = vsock_connect_saddr(addr->u.vsock.data, errp, callback, opaque);
fd = vsock_connect_saddr(addr->u.vsock.data, callback, opaque, errp);
break;

default:
Expand Down

0 comments on commit 1a9a7f2

Please sign in to comment.