Skip to content

Commit

Permalink
migration/ram: fix use after free of local_err
Browse files Browse the repository at this point in the history
local_err is used again in migration_bitmap_sync_precopy() after
precopy_notify(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200324153630.11882-6-vsementsov@virtuozzo.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(cherry picked from commit b4a1733)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
  • Loading branch information
Vladimir Sementsov-Ogievskiy authored and mdroth committed Jun 22, 2020
1 parent 09397e9 commit 1c8d9fb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions migration/ram.c
Expand Up @@ -1906,6 +1906,7 @@ static void migration_bitmap_sync_precopy(RAMState *rs)
*/
if (precopy_notify(PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC, &local_err)) {
error_report_err(local_err);
local_err = NULL;
}

migration_bitmap_sync(rs);
Expand Down

0 comments on commit 1c8d9fb

Please sign in to comment.