Skip to content

Commit

Permalink
hw/arm/exynos4210: Inline sysbus_create_varargs(EXYNOS4210_FIMD)
Browse files Browse the repository at this point in the history
We want to set another qdev property (a link) for the FIMD
device, we can not use sysbus_create_varargs() which only
passes sysbus base address and IRQs as arguments. Inline
it so we can set the link property in the next commit.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240216153517.49422-4-philmd@linaro.org>
  • Loading branch information
philmd committed Feb 26, 2024
1 parent c209366 commit 1cfe461
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions hw/arm/exynos4210.c
Original file line number Diff line number Diff line change
Expand Up @@ -769,11 +769,13 @@ static void exynos4210_realize(DeviceState *socdev, Error **errp)
}

/*** Display controller (FIMD) ***/
sysbus_create_varargs("exynos4210.fimd", EXYNOS4210_FIMD0_BASE_ADDR,
s->irq_table[exynos4210_get_irq(11, 0)],
s->irq_table[exynos4210_get_irq(11, 1)],
s->irq_table[exynos4210_get_irq(11, 2)],
NULL);
dev = qdev_new("exynos4210.fimd");
busdev = SYS_BUS_DEVICE(dev);
sysbus_realize_and_unref(busdev, &error_fatal);
sysbus_mmio_map(busdev, 0, EXYNOS4210_FIMD0_BASE_ADDR);
for (n = 0; n < 3; n++) {
sysbus_connect_irq(busdev, n, s->irq_table[exynos4210_get_irq(11, n)]);
}

sysbus_create_simple(TYPE_EXYNOS4210_EHCI, EXYNOS4210_EHCI_BASE_ADDR,
s->irq_table[exynos4210_get_irq(28, 3)]);
Expand Down

0 comments on commit 1cfe461

Please sign in to comment.