Skip to content

Commit

Permalink
qemu-io: Clean up global variable shadowing
Browse files Browse the repository at this point in the history
Fix:

  qemu-io.c:478:36: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
  static void add_user_command(char *optarg)
                                     ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14: note: previous declaration is here
  extern char *optarg;                    /* getopt(3) external variables */
               ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231004120019.93101-8-philmd@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
  • Loading branch information
philmd authored and Markus Armbruster committed Oct 6, 2023
1 parent 46bb944 commit 21c029e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions qemu-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -475,10 +475,10 @@ static int command_loop(void)
return last_error;
}

static void add_user_command(char *optarg)
static void add_user_command(char *user_cmd)
{
cmdline = g_renew(char *, cmdline, ++ncmdline);
cmdline[ncmdline-1] = optarg;
cmdline[ncmdline - 1] = user_cmd;
}

static void reenable_tty_echo(void)
Expand Down

0 comments on commit 21c029e

Please sign in to comment.