Skip to content

Commit

Permalink
tests/ssh_linux_malta: Fix 64-bit target tests
Browse files Browse the repository at this point in the history
Commit 9090d33 added tests for specific to the 32-bit
machines, which inadvertently make the 64-bit tests failing.
Now than we have this information available in the CPU_INFO
array, use it to have the 64-bit tests back.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Message-Id: <20191019153437.9820-12-f4bug@amsat.org>
  • Loading branch information
philmd authored and AMarkovic committed Oct 25, 2019
1 parent a7b198e commit 220ad85
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tests/acceptance/linux_ssh_mips_malta.py
Expand Up @@ -43,8 +43,8 @@ class LinuxSSH(Test):
}
}
CPU_INFO = {
32: {'kernel_release': '3.2.0-4-4kc-malta'},
64: {'kernel_release': '3.2.0-4-5kc-malta'}
32: {'cpu': 'MIPS 24Kc', 'kernel_release': '3.2.0-4-4kc-malta'},
64: {'cpu': 'MIPS 20Kc', 'kernel_release': '3.2.0-4-5kc-malta'}
}

def get_url(self, endianess, path=''):
Expand Down Expand Up @@ -155,16 +155,16 @@ def ssh_command_output_contains(self, cmd, exp):
else:
self.fail('"%s" output does not contain "%s"' % (cmd, exp))

def run_common_commands(self):
def run_common_commands(self, wordsize):
self.ssh_command_output_contains(
'cat /proc/cpuinfo',
'24Kc')
self.CPU_INFO[wordsize]['cpu'])
self.ssh_command_output_contains(
'uname -m',
'mips')
self.ssh_command_output_contains(
'uname -r',
'3.2.0-4-4kc-malta')
self.CPU_INFO[wordsize]['kernel_release'])
self.ssh_command_output_contains(
'cat /proc/interrupts',
'XT-PIC timer')
Expand Down Expand Up @@ -221,7 +221,7 @@ def check_mips_malta(self, uname_m, endianess):
stdout, _ = self.ssh_command('uname -a')
self.assertIn(True, [uname_m + " GNU/Linux" in line for line in stdout])

self.run_common_commands()
self.run_common_commands(wordsize)
self.shutdown_via_ssh()

def test_mips_malta32eb_kernel3_2_0(self):
Expand Down

0 comments on commit 220ad85

Please sign in to comment.