Skip to content

Commit

Permalink
target/hexagon/opcodes: Add missing varargs cleanup
Browse files Browse the repository at this point in the history
Fix a trivial incorrect usage of variable argument macros detected
by Coverity (missing_va_end: va_end was not called for ap).

Fixes: Coverity CID 1446720 (VARARGS)
Fixes: e3c00c2 ("Hexagon (target/hexagon) opcode data structures")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <20210223111253.2831285-1-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
  • Loading branch information
philmd authored and rth7680 committed Mar 7, 2021
1 parent 66a1807 commit 2526e69
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions target/hexagon/opcodes.c
Expand Up @@ -82,6 +82,7 @@ static void init_attribs(int tag, ...)
while ((attr = va_arg(ap, int)) != 0) {
set_bit(attr, opcode_attribs[tag]);
}
va_end(ap);
}

const OpcodeEncoding opcode_encodings[] = {
Expand Down

0 comments on commit 2526e69

Please sign in to comment.