Skip to content

Commit

Permalink
gdbstub: Correct invalid mentions of 'softmmu' by 'system'
Browse files Browse the repository at this point in the history
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240313213339.82071-3-philmd@linaro.org>
  • Loading branch information
philmd committed Apr 2, 2024
1 parent 9301969 commit 25f34eb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
20 changes: 10 additions & 10 deletions gdbstub/internals.h
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ void gdb_read_byte(uint8_t ch);

/*
* Packet acknowledgement - we handle this slightly differently
* between user and softmmu mode, mainly to deal with the differences
* between user and system mode, mainly to deal with the differences
* between the flexible chardev and the direct fd approaches.
*
* We currently don't support a negotiated QStartNoAckMode
Expand All @@ -125,7 +125,7 @@ void gdb_read_byte(uint8_t ch);
* gdb_got_immediate_ack() - check ok to continue
*
* Returns true to continue, false to re-transmit for user only, the
* softmmu stub always returns true.
* system stub always returns true.
*/
bool gdb_got_immediate_ack(void);
/* utility helpers */
Expand All @@ -135,12 +135,12 @@ CPUState *gdb_first_attached_cpu(void);
void gdb_append_thread_id(CPUState *cpu, GString *buf);
int gdb_get_cpu_index(CPUState *cpu);
unsigned int gdb_get_max_cpus(void); /* both */
bool gdb_can_reverse(void); /* softmmu, stub for user */
bool gdb_can_reverse(void); /* system emulation, stub for user */
int gdb_target_sigtrap(void); /* user */

void gdb_create_default_process(GDBState *s);

/* signal mapping, common for softmmu, specialised for user-mode */
/* signal mapping, common for system, specialised for user-mode */
int gdb_signal_to_target(int sig);
int gdb_target_signal_to_gdb(int sig);

Expand All @@ -157,12 +157,12 @@ void gdb_continue(void);
int gdb_continue_partial(char *newstates);

/*
* Helpers with separate softmmu and user implementations
* Helpers with separate system and user implementations
*/
void gdb_put_buffer(const uint8_t *buf, int len);

/*
* Command handlers - either specialised or softmmu or user only
* Command handlers - either specialised or system or user only
*/
void gdb_init_gdbserver_state(void);

Expand All @@ -187,7 +187,7 @@ typedef union GdbCmdVariant {

#define get_param(p, i) (&g_array_index(p, GdbCmdVariant, i))

void gdb_handle_query_rcmd(GArray *params, void *user_ctx); /* softmmu */
void gdb_handle_query_rcmd(GArray *params, void *user_ctx); /* system */
void gdb_handle_query_offsets(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_xfer_auxv(GArray *params, void *user_ctx); /*user */
void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx); /*user */
Expand All @@ -203,7 +203,7 @@ bool gdb_handle_detach_user(uint32_t pid); /* user */

void gdb_handle_query_attached(GArray *params, void *user_ctx); /* both */

/* softmmu only */
/* system only */
void gdb_handle_query_qemu_phy_mem_mode(GArray *params, void *user_ctx);
void gdb_handle_set_qemu_phy_mem_mode(GArray *params, void *user_ctx);

Expand All @@ -213,11 +213,11 @@ bool gdb_handled_syscall(void);
void gdb_disable_syscalls(void);
void gdb_syscall_reset(void);

/* user/softmmu specific syscall handling */
/* user/system specific syscall handling */
void gdb_syscall_handling(const char *syscall_packet);

/*
* Break/Watch point support - there is an implementation for softmmu
* Break/Watch point support - there is an implementation for system
* and user mode.
*/
bool gdb_supports_guest_debug(void);
Expand Down
2 changes: 1 addition & 1 deletion gdbstub/system.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* gdb server stub - softmmu specific bits
* gdb server stub - system specific bits
*
* Debug integration depends on support from the individual
* accelerators so most of this involves calling the ops helpers.
Expand Down

0 comments on commit 25f34eb

Please sign in to comment.