Skip to content

Commit

Permalink
tracetool: work around ust <sys/sdt.h> include conflict
Browse files Browse the repository at this point in the history
Both the dtrace and ust backends may include <sys/sdt.h> but LTTng
Userspace Tracer 2.11 and later requires SDT_USE_VARIADIC to be defined
before including the header file.

This is a classic problem with C header files included from different
parts of a program. If the same header is included twice within the same
compilation unit then the first inclusion determines the macro
environment.

Work around this by defining SDT_USE_VARIADIC in the dtrace backend too.
It doesn't hurt and fixes a missing STAP_PROBEV() compiler error when
the ust backend is enabled together with the dtrace backend.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200625140757.237012-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
stefanhaRH committed Jul 7, 2020
1 parent 7623b5b commit 27e08ba
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions scripts/tracetool/backend/dtrace.py
Expand Up @@ -40,6 +40,12 @@ def generate_h_begin(events, group):
else:
header = "trace-dtrace.h"

# Workaround for ust backend, which also includes <sys/sdt.h> and may
# require SDT_USE_VARIADIC to be defined. If dtrace includes <sys/sdt.h>
# first without defining SDT_USE_VARIADIC then ust breaks because the
# STAP_PROBEV() macro is not defined.
out('#define SDT_USE_VARIADIC 1')

out('#include "%s"' % header,
'')

Expand Down

0 comments on commit 27e08ba

Please sign in to comment.