Skip to content

Commit

Permalink
s390x/kvm: synchronize guest floating point registers
Browse files Browse the repository at this point in the history
Add code to kvm_arch_get_registers and kvm_arch_put_registers to
save/restore floating point registers. This missing sync was
unnoticed until migration of userspace that uses fprs.

Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
[Update patch to latest upstream]
Cc: qemu-stable@nongnu.org
Reviewed-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

(cherry picked from commit 85ad623)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
  • Loading branch information
Jason J. Herne authored and mdroth committed Aug 6, 2014
1 parent 5a782bb commit 29cffd3
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions target-s390x/kvm.c
Expand Up @@ -164,6 +164,7 @@ int kvm_arch_put_registers(CPUState *cs, int level)
CPUS390XState *env = &cpu->env;
struct kvm_sregs sregs;
struct kvm_regs regs;
struct kvm_fpu fpu;
int r;
int i;

Expand All @@ -186,6 +187,17 @@ int kvm_arch_put_registers(CPUState *cs, int level)
}
}

/* Floating point */
for (i = 0; i < 16; i++) {
fpu.fprs[i] = env->fregs[i].ll;
}
fpu.fpc = env->fpc;

r = kvm_vcpu_ioctl(cs, KVM_SET_FPU, &fpu);
if (r < 0) {
return r;
}

/* Do we need to save more than that? */
if (level == KVM_PUT_RUNTIME_STATE) {
return 0;
Expand Down Expand Up @@ -251,6 +263,7 @@ int kvm_arch_get_registers(CPUState *cs)
CPUS390XState *env = &cpu->env;
struct kvm_sregs sregs;
struct kvm_regs regs;
struct kvm_fpu fpu;
int i, r;

/* get the PSW */
Expand Down Expand Up @@ -291,6 +304,16 @@ int kvm_arch_get_registers(CPUState *cs)
}
}

/* Floating point */
r = kvm_vcpu_ioctl(cs, KVM_GET_FPU, &fpu);
if (r < 0) {
return r;
}
for (i = 0; i < 16; i++) {
env->fregs[i].ll = fpu.fprs[i];
}
env->fpc = fpu.fpc;

/* The prefix */
if (cap_sync_regs && cs->kvm_run->kvm_valid_regs & KVM_SYNC_PREFIX) {
env->psa = cs->kvm_run->s.regs.prefix;
Expand Down

0 comments on commit 29cffd3

Please sign in to comment.