Skip to content

Commit

Permalink
util/uri: Add overflow check to rfc3986_parse_port
Browse files Browse the repository at this point in the history
And while at it, replace tabs by eight spaces in this function.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <1424887718-10800-2-git-send-email-mreitz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
XanClic authored and bonzini committed Mar 18, 2015
1 parent 8b2f0ab commit 2b21233
Showing 1 changed file with 14 additions and 10 deletions.
24 changes: 14 additions & 10 deletions util/uri.c
Expand Up @@ -320,19 +320,23 @@ static int
rfc3986_parse_port(URI *uri, const char **str)
{
const char *cur = *str;
int port = 0;

if (ISA_DIGIT(cur)) {
if (uri != NULL)
uri->port = 0;
while (ISA_DIGIT(cur)) {
if (uri != NULL)
uri->port = uri->port * 10 + (*cur - '0');
cur++;
}
*str = cur;
return(0);
while (ISA_DIGIT(cur)) {
port = port * 10 + (*cur - '0');
if (port > 65535) {
return 1;
}
cur++;
}
if (uri) {
uri->port = port;
}
*str = cur;
return 0;
}
return(1);
return 1;
}

/**
Expand Down

0 comments on commit 2b21233

Please sign in to comment.