Skip to content

Commit

Permalink
Merge remote-tracking branch 'remotes/kiszka/queues/slirp' into staging
Browse files Browse the repository at this point in the history
* remotes/kiszka/queues/slirp:
  slirp smb with modern win guests when samba is also running on host
  qemu/slirp: Fix SMB security configuration on newer samba versions

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
pm215 committed Mar 12, 2014
2 parents 7602e3e + 5c1e189 commit 2c3445b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions net/slirp.c
Expand Up @@ -529,7 +529,8 @@ static int slirp_smb(SlirpState* s, const char *exported_dir,
"state directory=%s\n"
"log file=%s/log.smbd\n"
"smb passwd file=%s/smbpasswd\n"
"security = share\n"
"security = user\n"
"map to guest = Bad User\n"
"[qemu]\n"
"path=%s\n"
"read only=no\n"
Expand All @@ -549,7 +550,8 @@ static int slirp_smb(SlirpState* s, const char *exported_dir,
snprintf(smb_cmdline, sizeof(smb_cmdline), "%s -s %s",
CONFIG_SMBD_COMMAND, smb_conf);

if (slirp_add_exec(s->slirp, 0, smb_cmdline, &vserver_addr, 139) < 0) {
if (slirp_add_exec(s->slirp, 0, smb_cmdline, &vserver_addr, 139) < 0 ||
slirp_add_exec(s->slirp, 0, smb_cmdline, &vserver_addr, 445) < 0) {
slirp_smb_cleanup(s);
error_report("conflicting/invalid smbserver address");
return -1;
Expand Down

0 comments on commit 2c3445b

Please sign in to comment.