Skip to content

Commit

Permalink
aio: Another fix to the walking_handlers logic
Browse files Browse the repository at this point in the history
The AIO dispatch loop will call QLIST_REMOVE and g_free even if there
are other pending calls to qemu_aio_wait outside the current one.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
bonzini authored and kevmw committed Sep 28, 2012
1 parent ca0defb commit 2db2bfc
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions aio.c
Expand Up @@ -159,14 +159,14 @@ bool qemu_aio_wait(void)

/* if we have any readable fds, dispatch event */
if (ret > 0) {
walking_handlers++;

/* we have to walk very carefully in case
* qemu_aio_set_fd_handler is called while we're walking */
node = QLIST_FIRST(&aio_handlers);
while (node) {
AioHandler *tmp;

walking_handlers++;

if (!node->deleted &&
FD_ISSET(node->fd, &rdfds) &&
node->io_read) {
Expand All @@ -181,13 +181,13 @@ bool qemu_aio_wait(void)
tmp = node;
node = QLIST_NEXT(node, node);

if (tmp->deleted) {
walking_handlers--;

if (!walking_handlers && tmp->deleted) {
QLIST_REMOVE(tmp, node);
g_free(tmp);
}
}

walking_handlers--;
}

return true;
Expand Down

0 comments on commit 2db2bfc

Please sign in to comment.