Skip to content

Commit

Permalink
block/vvfat.c: fix warnings with _FORTIFY_SOURCE
Browse files Browse the repository at this point in the history
CC    block/vvfat.o
cc1: warnings being treated as errors
block/vvfat.c: In function 'commit_one_file':
block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result
make: *** [block/vvfat.o] Error 1
  CC    block/vvfat.o
In file included from /usr/include/stdio.h:912,
                 from ./qemu-common.h:19,
                 from block/vvfat.c:27:
In function 'snprintf',
    inlined from 'init_directories' at block/vvfat.c:871,
    inlined from 'vvfat_open' at block/vvfat.c:1068:
/usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will always overflow destination buffer
make: *** [block/vvfat.o] Error 1

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  • Loading branch information
kiryl authored and Anthony Liguori committed Jan 26, 2010
1 parent 1640366 commit 2dedf83
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions block/vvfat.c
Expand Up @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s,
{
direntry_t* entry=array_get_next(&(s->directory));
entry->attributes=0x28; /* archive | volume label */
snprintf((char*)entry->name,11,"QEMU VVFAT");
memcpy(entry->name,"QEMU VVF",8);
memcpy(entry->extension,"AT ",3);
}

/* Now build FAT, and write back information into directory */
Expand Down Expand Up @@ -2256,7 +2257,11 @@ static int commit_one_file(BDRVVVFATState* s,
c = c1;
}

ftruncate(fd, size);
if (ftruncate(fd, size)) {
perror("ftruncate()");
close(fd);
return -4;
}
close(fd);

return commit_mappings(s, first_cluster, dir_index);
Expand Down

0 comments on commit 2dedf83

Please sign in to comment.