Skip to content

Commit

Permalink
migration/postcopy: reduce memset when it is zero page and matches_ta…
Browse files Browse the repository at this point in the history
…rget_page_size

In this case, page_buffer content would not be used.

Skip this to save some time.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
  • Loading branch information
Wei Yang authored and Juan Quintela committed Jan 20, 2020
1 parent e65cec5 commit 2e36bc1
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion migration/ram.c
Expand Up @@ -4126,7 +4126,13 @@ static int ram_load_postcopy(QEMUFile *f)
switch (flags & ~RAM_SAVE_FLAG_CONTINUE) {
case RAM_SAVE_FLAG_ZERO:
ch = qemu_get_byte(f);
memset(page_buffer, ch, TARGET_PAGE_SIZE);
/*
* Can skip to set page_buffer when
* this is a zero page and (block->page_size == TARGET_PAGE_SIZE).
*/
if (ch || !matches_target_page_size) {
memset(page_buffer, ch, TARGET_PAGE_SIZE);
}
if (ch) {
all_zero = false;
}
Expand Down

0 comments on commit 2e36bc1

Please sign in to comment.