Skip to content

Commit

Permalink
qmp-commands: move 'memsave' doc to schema
Browse files Browse the repository at this point in the history
Notice that "cpu" argument is actually "cpu-index" in the json.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
  • Loading branch information
elmarco authored and Markus Armbruster committed Jan 16, 2017
1 parent a7b8375 commit 30831b6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 20 deletions.
20 changes: 0 additions & 20 deletions docs/qmp-commands.txt
Expand Up @@ -219,26 +219,6 @@ Example:

Note: CPUs' indexes are obtained with the 'query-cpus' command.

memsave
-------

Save to disk virtual memory dump starting at 'val' of size 'size'.

Arguments:

- "val": the starting address (json-int)
- "size": the memory size, in bytes (json-int)
- "filename": file path (json-string)
- "cpu": virtual CPU index (json-int, optional)

Example:

-> { "execute": "memsave",
"arguments": { "val": 10,
"size": 100,
"filename": "/tmp/virtual-mem-dump" } }
<- { "return": {} }

pmemsave
--------

Expand Down
9 changes: 9 additions & 0 deletions qapi-schema.json
Expand Up @@ -2231,6 +2231,15 @@
# Since: 0.14.0
#
# Notes: Errors were not reliably returned until 1.1
#
# Example:
#
# -> { "execute": "memsave",
# "arguments": { "val": 10,
# "size": 100,
# "filename": "/tmp/virtual-mem-dump" } }
# <- { "return": {} }
#
##
{ 'command': 'memsave',
'data': {'val': 'int', 'size': 'int', 'filename': 'str', '*cpu-index': 'int'} }
Expand Down

0 comments on commit 30831b6

Please sign in to comment.