Skip to content

Commit

Permalink
9pfs: local: statfs: don't follow symlinks
Browse files Browse the repository at this point in the history
The local_statfs() callback is vulnerable to symlink attacks because it
calls statfs() which follows symbolic links in all path elements.

This patch converts local_statfs() to rely on open_nofollow() and fstatfs()
instead.

This partly fixes CVE-2016-9602.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
gkurz committed Feb 28, 2017
1 parent a33eda0 commit 31e51d1
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions hw/9pfs/9p-local.c
Expand Up @@ -1077,13 +1077,11 @@ static int local_fsync(FsContext *ctx, int fid_type,

static int local_statfs(FsContext *s, V9fsPath *fs_path, struct statfs *stbuf)
{
char *buffer;
int ret;
char *path = fs_path->data;
int fd, ret;

buffer = rpath(s, path);
ret = statfs(buffer, stbuf);
g_free(buffer);
fd = local_open_nofollow(s, fs_path->data, O_RDONLY, 0);
ret = fstatfs(fd, stbuf);
close_preserve_errno(fd);
return ret;
}

Expand Down

0 comments on commit 31e51d1

Please sign in to comment.