Skip to content

Commit

Permalink
iotests: Add test for a nonexistent NBD export
Browse files Browse the repository at this point in the history
Trying to connect to a nonexistent NBD export should not crash the
server.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
XanClic committed Feb 2, 2016
1 parent 15cfba6 commit 3425039
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 0 deletions.
73 changes: 73 additions & 0 deletions tests/qemu-iotests/143
@@ -0,0 +1,73 @@
#!/bin/bash
#
# Test case for connecting to a non-existing NBD export name
#
# Copyright (C) 2016 Red Hat, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#

# creator
owner=mreitz@redhat.com

seq="$(basename $0)"
echo "QA output created by $seq"

here="$PWD"
tmp=/tmp/$$
status=1 # failure is the default!

_cleanup()
{
rm -f "$TEST_DIR/nbd"
}
trap "_cleanup; exit \$status" 0 1 2 3 15

# get standard environment, filters and checks
. ./common.rc
. ./common.filter
. ./common.qemu

_supported_fmt generic
_supported_proto generic
_supported_os Linux

keep_stderr=y \
_launch_qemu 2> >(_filter_nbd)

_send_qemu_cmd $QEMU_HANDLE \
"{ 'execute': 'qmp_capabilities' }" \
'return'

_send_qemu_cmd $QEMU_HANDLE \
"{ 'execute': 'nbd-server-start',
'arguments': { 'addr': { 'type': 'unix',
'data': { 'path': '$TEST_DIR/nbd' }}}}" \
'return'

# This should just result in a client error, not in the server crashing
$QEMU_IO_PROG -f raw -c quit \
"nbd+unix:///no_such_export?socket=$TEST_DIR/nbd" 2>&1 \
| _filter_qemu_io | _filter_nbd

_send_qemu_cmd $QEMU_HANDLE \
"{ 'execute': 'quit' }" \
'return'

wait=1 _cleanup_qemu

# success, all done
echo '*** done'
rm -f $seq.full
status=0
7 changes: 7 additions & 0 deletions tests/qemu-iotests/143.out
@@ -0,0 +1,7 @@
QA output created by 143
{"return": {}}
{"return": {}}
can't open device nbd+unix:///no_such_export?socket=TEST_DIR/nbd: Failed to read export length
{"return": {}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
*** done
1 change: 1 addition & 0 deletions tests/qemu-iotests/group
Expand Up @@ -142,3 +142,4 @@
138 rw auto quick
139 rw auto quick
142 auto
143 auto quick

0 comments on commit 3425039

Please sign in to comment.