Skip to content

Commit

Permalink
hw/tpm: TIS on sysbus: Remove unsupport ppi command line option
Browse files Browse the repository at this point in the history
The ppi command line option for the TIS device on sysbus never worked
and caused an immediate segfault. Remove support for it since it also
needs support in the firmware and needs testing inside the VM.

Reproducer with the ppi=on option passed:

qemu-system-aarch64 \
   -machine virt,gic-version=3 \
   -m 4G  \
   -nographic -no-acpi \
   -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \
   -tpmdev emulator,id=tpm0,chardev=chrtpm \
   -device tpm-tis-device,tpmdev=tpm0,ppi=on
[...]
Segmentation fault (core dumped)

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20230713171955.149236-1-stefanb@linux.ibm.com
(cherry picked from commit 4c46fe2)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
stefanberger authored and Michael Tokarev committed Sep 20, 2023
1 parent 70c97e7 commit 36540b3
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hw/tpm/tpm_tis_sysbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
static Property tpm_tis_sysbus_properties[] = {
DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false),
DEFINE_PROP_END_OF_LIST(),
};

Expand Down

0 comments on commit 36540b3

Please sign in to comment.