Skip to content

Commit

Permalink
hw/loongarch/virt: Remove unused ISA Bus
Browse files Browse the repository at this point in the history
The LoongArch 'virt' machine doesn't use its ISA I/O region.

If a ISA device were to be mapped there, there is no support
for ISA IRQ. Unlikely useful. Simply remove.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Message-Id: <20231010135342.40219-3-philmd@linaro.org>
Signed-off-by: Song Gao <gaosong@loongson.cn>
  • Loading branch information
philmd authored and gaosong-loongson committed Oct 13, 2023
1 parent cb041ae commit 3866e2f
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion hw/loongarch/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ config LOONGARCH_VIRT
imply VIRTIO_VGA
imply PCI_DEVICES
imply NVDIMM
select ISA_BUS
select SERIAL
select VIRTIO_PCI
select PLATFORM_BUS
Expand Down
5 changes: 0 additions & 5 deletions hw/loongarch/virt.c
Original file line number Diff line number Diff line change
Expand Up @@ -878,11 +878,6 @@ static void loongarch_init(MachineState *machine)
machine_memory_devices_init(machine, device_mem_base, device_mem_size);
}

/* Add isa io region */
memory_region_init_alias(&lams->isa_io, NULL, "isa-io",
get_system_io(), 0, VIRT_ISA_IO_SIZE);
memory_region_add_subregion(address_space_mem, VIRT_ISA_IO_BASE,
&lams->isa_io);
/* load the BIOS image. */
loongarch_firmware_init(lams);

Expand Down
3 changes: 0 additions & 3 deletions include/hw/loongarch/virt.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#define LOONGARCH_MAX_CPUS 256

#define VIRT_ISA_IO_BASE 0x18000000UL
#define VIRT_ISA_IO_SIZE 0x0004000
#define VIRT_FWCFG_BASE 0x1e020000UL
#define VIRT_BIOS_BASE 0x1c000000UL
#define VIRT_BIOS_SIZE (4 * MiB)
Expand All @@ -38,7 +36,6 @@ struct LoongArchMachineState {

MemoryRegion lowmem;
MemoryRegion highmem;
MemoryRegion isa_io;
MemoryRegion bios;
bool bios_loaded;
/* State for other subsystems/APIs: */
Expand Down

0 comments on commit 3866e2f

Please sign in to comment.