Skip to content

Commit

Permalink
backends: Reduce variable scope in host_memory_backend_memory_complete
Browse files Browse the repository at this point in the history
Reduce the &local_err variable use and remove the 'out:' label.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Message-Id: <20231120213301.24349-18-philmd@linaro.org>
  • Loading branch information
philmd committed Jan 5, 2024
1 parent fdb63cf commit 3961613
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions backends/hostmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
{
HostMemoryBackend *backend = MEMORY_BACKEND(uc);
HostMemoryBackendClass *bc = MEMORY_BACKEND_GET_CLASS(uc);
Error *local_err = NULL;
void *ptr;
uint64_t sz;

Expand Down Expand Up @@ -400,15 +399,16 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
* specified NUMA policy in place.
*/
if (backend->prealloc) {
Error *local_err = NULL;

qemu_prealloc_mem(memory_region_get_fd(&backend->mr), ptr, sz,
backend->prealloc_threads,
backend->prealloc_context, &local_err);
if (local_err) {
goto out;
error_propagate(errp, local_err);
return;
}
}
out:
error_propagate(errp, local_err);
}

static bool
Expand Down

0 comments on commit 3961613

Please sign in to comment.