Skip to content

Commit

Permalink
qxl: remove assert in qxl_pre_save.
Browse files Browse the repository at this point in the history
Since commit 551dbd0 ("migration: check pre_save return in
vmstate_save_state") the pre_save hook can fail.  So lets finally
use that to drop the guest-triggerable assert in qxl_pre_save().

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210721093347.338536-2-kraxel@redhat.com>
  • Loading branch information
kraxel committed Jul 22, 2021
1 parent dc2deab commit 39b8a18
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion hw/display/qxl.c
Expand Up @@ -2283,7 +2283,9 @@ static int qxl_pre_save(void *opaque)
} else {
d->last_release_offset = (uint8_t *)d->last_release - ram_start;
}
assert(d->last_release_offset < d->vga.vram_size);
if (d->last_release_offset < d->vga.vram_size) {
return 1;
}

return 0;
}
Expand Down

0 comments on commit 39b8a18

Please sign in to comment.