Skip to content

Commit

Permalink
virtiofsd: extract root inode init into setup_root()
Browse files Browse the repository at this point in the history
Inititialize the root inode in a single place.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
dgilbert:
with fix suggested by Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  • Loading branch information
Miklos Szeredi authored and dagrh committed Jan 23, 2020
1 parent 9de4fab commit 3ca8a2b
Showing 1 changed file with 25 additions and 10 deletions.
35 changes: 25 additions & 10 deletions tools/virtiofsd/passthrough_ll.c
Expand Up @@ -2351,6 +2351,30 @@ static void log_func(enum fuse_log_level level, const char *fmt, va_list ap)
}
}

static void setup_root(struct lo_data *lo, struct lo_inode *root)
{
int fd, res;
struct stat stat;

fd = open("/", O_PATH);
if (fd == -1) {
fuse_log(FUSE_LOG_ERR, "open(%s, O_PATH): %m\n", lo->source);
exit(1);
}

res = fstatat(fd, "", &stat, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW);
if (res == -1) {
fuse_log(FUSE_LOG_ERR, "fstatat(%s): %m\n", lo->source);
exit(1);
}

root->is_symlink = false;
root->fd = fd;
root->ino = stat.st_ino;
root->dev = stat.st_dev;
root->refcount = 2;
}

int main(int argc, char *argv[])
{
struct fuse_args args = FUSE_ARGS_INIT(argc, argv);
Expand Down Expand Up @@ -2426,8 +2450,6 @@ int main(int argc, char *argv[])
if (lo.debug) {
current_log_level = FUSE_LOG_DEBUG;
}
lo.root.refcount = 2;

if (lo.source) {
struct stat stat;
int res;
Expand All @@ -2446,7 +2468,6 @@ int main(int argc, char *argv[])
} else {
lo.source = "/";
}
lo.root.is_symlink = false;
if (!lo.timeout_set) {
switch (lo.cache) {
case CACHE_NEVER:
Expand All @@ -2466,13 +2487,6 @@ int main(int argc, char *argv[])
exit(1);
}

lo.root.fd = open(lo.source, O_PATH);

if (lo.root.fd == -1) {
fuse_log(FUSE_LOG_ERR, "open(\"%s\", O_PATH): %m\n", lo.source);
exit(1);
}

se = fuse_session_new(&args, &lo_oper, sizeof(lo_oper), &lo);
if (se == NULL) {
goto err_out1;
Expand All @@ -2495,6 +2509,7 @@ int main(int argc, char *argv[])

setup_sandbox(&lo, se, opts.syslog);

setup_root(&lo, &lo.root);
/* Block until ctrl+c or fusermount -u */
ret = virtio_loop(se);

Expand Down

0 comments on commit 3ca8a2b

Please sign in to comment.