Skip to content

Commit

Permalink
target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_co…
Browse files Browse the repository at this point in the history
…nv()

In handle_simd_shift_fpint_conv(), the combination of is_double == true,
is_scalar == false and is_q == false is an unallocated encoding; the
'both parts false' case of the nested ?: expression for calculating
maxpass is therefore unreachable and can be removed.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Message-id: 1402171881-14343-4-git-send-email-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Jun 19, 2014
1 parent 220ad4c commit 4063452
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target-arm/translate-a64.c
Expand Up @@ -6539,7 +6539,7 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar,
tcg_shift = tcg_const_i32(fracbits);

if (is_double) {
int maxpass = is_scalar ? 1 : is_q ? 2 : 1;
int maxpass = is_scalar ? 1 : 2;

for (pass = 0; pass < maxpass; pass++) {
TCGv_i64 tcg_op = tcg_temp_new_i64();
Expand Down

0 comments on commit 4063452

Please sign in to comment.