Skip to content

Commit

Permalink
qemu-ga: don't leak a file descriptor upon failed lockf
Browse files Browse the repository at this point in the history
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  • Loading branch information
Jim Meyering authored and Anthony Liguori committed Aug 22, 2012
1 parent 0ec6450 commit 4144f12
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions qemu-ga.c
Expand Up @@ -247,6 +247,9 @@ static bool ga_open_pidfile(const char *pidfile)
pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
g_critical("Cannot lock pid file, %s", strerror(errno));
if (pidfd != -1) {
close(pidfd);
}
return false;
}

Expand Down

0 comments on commit 4144f12

Please sign in to comment.