Skip to content

Commit

Permalink
qapi/parser: Use @staticmethod where appropriate
Browse files Browse the repository at this point in the history
No self, no thank you!

(Quiets pylint warnings.)

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210519183951.3946870-9-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
  • Loading branch information
jnsnow authored and Markus Armbruster committed May 20, 2021
1 parent 234dce2 commit 43b1be6
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions scripts/qapi/parser.py
Expand Up @@ -130,7 +130,8 @@ def reject_expr_doc(doc):
"documentation for '%s' is not followed by the definition"
% doc.symbol)

def _include(self, include, info, incl_fname, previously_included):
@staticmethod
def _include(include, info, incl_fname, previously_included):
incl_abs_fname = os.path.abspath(incl_fname)
# catch inclusion cycle
inf = info
Expand All @@ -151,7 +152,8 @@ def _include(self, include, info, incl_fname, previously_included):
f"can't read include file '{incl_fname}': {err.strerror}"
) from err

def _check_pragma_list_of_str(self, name, value, info):
@staticmethod
def _check_pragma_list_of_str(name, value, info):
if (not isinstance(value, list)
or any([not isinstance(elt, str) for elt in value])):
raise QAPISemError(
Expand Down

0 comments on commit 43b1be6

Please sign in to comment.