Skip to content

Commit

Permalink
bsd-user: Remove image_info.start_brk
Browse files Browse the repository at this point in the history
This has the same value is image_info.brk, which is also logged,
and is otherwise unused.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230818175736.144194-4-richard.henderson@linaro.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Signed-off-by: Warner Losh <imp@bsdimp.com>
  • Loading branch information
rth7680 authored and bsdimp committed Aug 28, 2023
1 parent 7db1873 commit 4436e2f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion bsd-user/elfload.c
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ int load_elf_binary(struct bsd_binprm *bprm, struct target_pt_regs *regs,
bprm->stringp, &elf_ex, load_addr,
et_dyn_addr, interp_load_addr, info);
info->load_addr = reloc_func_desc;
info->start_brk = info->brk = elf_brk;
info->brk = elf_brk;
info->start_stack = bprm->p;
info->load_bias = 0;

Expand Down
2 changes: 0 additions & 2 deletions bsd-user/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,6 @@ int main(int argc, char **argv)
fprintf(f, "page layout changed following binary load\n");
page_dump(f);

fprintf(f, "start_brk 0x" TARGET_ABI_FMT_lx "\n",
info->start_brk);
fprintf(f, "end_code 0x" TARGET_ABI_FMT_lx "\n",
info->end_code);
fprintf(f, "start_code 0x" TARGET_ABI_FMT_lx "\n",
Expand Down
1 change: 0 additions & 1 deletion bsd-user/qemu.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ struct image_info {
abi_ulong end_code;
abi_ulong start_data;
abi_ulong end_data;
abi_ulong start_brk;
abi_ulong brk;
abi_ulong rss;
abi_ulong start_stack;
Expand Down

0 comments on commit 4436e2f

Please sign in to comment.