Skip to content

Commit

Permalink
tests: don't check if qtest_spapr_boot() returns NULL
Browse files Browse the repository at this point in the history
qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot()
and qtest_vboot() calls g_malloc(),
and g_malloc() never fails:
if memory allocation fails, the application is terminated.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
  • Loading branch information
vivier authored and dgibson committed Oct 27, 2016
1 parent f62e0bb commit 458f3b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions tests/libqos/libqos.c
Expand Up @@ -10,6 +10,8 @@
/**
* Launch QEMU with the given command line,
* and then set up interrupts and our guest malloc interface.
* Never returns NULL:
* Terminates the application in case an error is encountered.
*/
QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap)
{
Expand Down
1 change: 0 additions & 1 deletion tests/rtas-test.c
Expand Up @@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void)
time_t t1, t2;

qs = qtest_spapr_boot("-machine pseries");
g_assert(qs != NULL);

t1 = time(NULL);
ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns);
Expand Down

0 comments on commit 458f3b2

Please sign in to comment.