Skip to content

Commit

Permalink
s390x/cpu_models: drop "msa5" from the TCG "max" model
Browse files Browse the repository at this point in the history
We don't include the "msa5" feature in the "qemu" model because it
generates a warning. The PoP states:

"The message-security-assist extension 5 requires
the secure-hash-algorithm (SHA-512) capabilities of
the message-security-assist extension 2 as a prereq-
uisite. (March, 2015)"

As SHA-512 won't be supported in the near future, let's just drop the
feature from the "max" model. This avoids the warning and allows us for
making the "max" model match the "qemu" model (except for compat
machines). We don't lose much, as we only implement the function stubs
for MSA, excluding any real subfunctions.

Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/897
Message-Id: <20220428094708.84835-3-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
davidhildenbrand authored and huth committed May 4, 2022
1 parent db67a6f commit 4756b10
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions target/s390x/gen-features.c
Expand Up @@ -743,8 +743,6 @@ static uint16_t qemu_LATEST[] = {
};
/* add all new definitions before this point */
static uint16_t qemu_MAX[] = {
/* generates a dependency warning, leave it out for now */
S390_FEAT_MSA_EXT_5,
};

/****** END FEATURE DEFS ******/
Expand Down

0 comments on commit 4756b10

Please sign in to comment.