Skip to content

Commit

Permalink
qapi: Replace qmp_dispatch()'s TODO comment by an explanation
Browse files Browse the repository at this point in the history
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200317115459.31821-25-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
  • Loading branch information
Markus Armbruster committed Mar 17, 2020
1 parent a62c617 commit 4a88373
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion qapi/qmp-dispatch.c
Expand Up @@ -162,7 +162,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
g_assert(!ret);
return NULL;
} else if (!ret) {
/* TODO turn into assertion */
/*
* When the command's schema has no 'returns', cmd->fn()
* leaves @ret null. The QMP spec calls for an empty object
* then; supply it.
*/
ret = QOBJECT(qdict_new());
}

Expand Down

0 comments on commit 4a88373

Please sign in to comment.