Skip to content

Commit

Permalink
i386/kvm: introduce tsc_is_stable_and_known()
Browse files Browse the repository at this point in the history
Move the "is TSC stable and known" condition to a reusable helper.

Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20170807085703.32267-4-lprosek@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
ladipro authored and bonzini committed Sep 19, 2017
1 parent ddb98b5 commit 4bb95b8
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions target/i386/kvm.c
Expand Up @@ -611,6 +611,15 @@ static int kvm_arch_set_tsc_khz(CPUState *cs)
return 0;
}

static bool tsc_is_stable_and_known(CPUX86State *env)
{
if (!env->tsc_khz) {
return false;
}
return (env->features[FEAT_8000_0007_EDX] & CPUID_APM_INVTSC)
|| env->user_tsc_khz;
}

static int hyperv_handle_properties(CPUState *cs)
{
X86CPU *cpu = X86_CPU(cs);
Expand Down Expand Up @@ -986,9 +995,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
&& cpu->expose_kvm
&& kvm_base == KVM_CPUID_SIGNATURE
/* TSC clock must be stable and known for this feature. */
&& ((env->features[FEAT_8000_0007_EDX] & CPUID_APM_INVTSC)
|| env->user_tsc_khz != 0)
&& env->tsc_khz != 0) {
&& tsc_is_stable_and_known(env)) {

c = &cpuid_data.entries[cpuid_i++];
c->function = KVM_CPUID_SIGNATURE | 0x10;
Expand Down

0 comments on commit 4bb95b8

Please sign in to comment.