Skip to content

Commit

Permalink
s390x/css: fix control flags during csch
Browse files Browse the repository at this point in the history
From the beginning, css support contained an error in csch handling:
instead of setting the clear bit in the function control bits twice, we
need to set the clear pending bit in the activity control bits. Let's
fix this.

Cc: qemu-stable@nongnu.org
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
  • Loading branch information
Halil Pasic authored and cohuck committed Jan 27, 2016
1 parent fba9110 commit 4c6bf79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/s390x/css.c
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ int css_do_csch(SubchDev *sch)

/* Trigger the clear function. */
s->ctrl &= ~(SCSW_CTRL_MASK_FCTL | SCSW_CTRL_MASK_ACTL);
s->ctrl |= SCSW_FCTL_CLEAR_FUNC | SCSW_FCTL_CLEAR_FUNC;
s->ctrl |= SCSW_FCTL_CLEAR_FUNC | SCSW_ACTL_CLEAR_PEND;

do_subchannel_work(sch, NULL);
ret = 0;
Expand Down

0 comments on commit 4c6bf79

Please sign in to comment.