Skip to content

Commit

Permalink
memory: Rename memory_region_do_writeback -> memory_region_writeback
Browse files Browse the repository at this point in the history
We usually use '_do_' for internal functions. Rename
memory_region_do_writeback() as memory_region_writeback().

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20200508062456.23344-2-philmd@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
philmd authored and stefanhaRH committed Jun 5, 2020
1 parent dfd5ddb commit 4dfe59d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions include/exec/memory.h
Expand Up @@ -1474,14 +1474,14 @@ void *memory_region_get_ram_ptr(MemoryRegion *mr);
void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize,
Error **errp);
/**
* memory_region_do_writeback: Trigger cache writeback or msync for
* memory_region_writeback: Trigger cache writeback or msync for
* selected address range
*
* @mr: the memory region to be updated
* @addr: the initial address of the range to be written back
* @size: the size of the range to be written back
*/
void memory_region_do_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size);
void memory_region_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size);

/**
* memory_region_set_log: Turn dirty logging on or off for a region.
Expand Down
2 changes: 1 addition & 1 deletion memory.c
Expand Up @@ -2198,7 +2198,7 @@ void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, Error **errp
}


void memory_region_do_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size)
void memory_region_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size)
{
/*
* Might be extended case needed to cover
Expand Down
2 changes: 1 addition & 1 deletion target/arm/helper.c
Expand Up @@ -6813,7 +6813,7 @@ static void dccvap_writefn(CPUARMState *env, const ARMCPRegInfo *opaque,
mr = memory_region_from_host(haddr, &offset);

if (mr) {
memory_region_do_writeback(mr, offset, dline_size);
memory_region_writeback(mr, offset, dline_size);
}
}
}
Expand Down

0 comments on commit 4dfe59d

Please sign in to comment.