Skip to content

Commit

Permalink
qemu-iotests: map underscore to dash in QMP argument names
Browse files Browse the repository at this point in the history
iotests.py provides a convenience function that uses Python keyword
arguments to represent QMP command arguments.  However, almost all
QMP commands use dashes for argument names (the sole exception is
block_set_io_throttle), and dashes are not allowed in a keyword
argument name.  Hence provide automatic conversion of underscores
to dashes.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
bonzini authored and kevmw committed Sep 28, 2012
1 parent 8f96b5b commit 4f45056
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tests/qemu-iotests/iotests.py
Expand Up @@ -19,6 +19,7 @@
import os
import re
import subprocess
import string
import unittest
import sys; sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'QMP'))
import qmp
Expand Down Expand Up @@ -96,9 +97,14 @@ def shutdown(self):
os.remove(self._qemu_log_path)
self._popen = None

underscore_to_dash = string.maketrans('_', '-')
def qmp(self, cmd, **args):
'''Invoke a QMP command and return the result dict'''
return self._qmp.cmd(cmd, args=args)
qmp_args = dict()
for k in args.keys():
qmp_args[k.translate(self.underscore_to_dash)] = args[k]

return self._qmp.cmd(cmd, args=qmp_args)

def get_qmp_events(self, wait=False):
'''Poll for queued QMP events and return a list of dicts'''
Expand Down

0 comments on commit 4f45056

Please sign in to comment.