Skip to content

Commit

Permalink
accel: Replace current_machine->accelerator by current_accel() wrapper
Browse files Browse the repository at this point in the history
We actually want to access the accelerator, not the machine, so
use the current_accel() wrapper instead.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200121110349.25842-10-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
philmd authored and bonzini committed Jan 24, 2020
1 parent ce7cdeb commit 4f7f589
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 11 deletions.
4 changes: 2 additions & 2 deletions accel/kvm/kvm-all.c
Expand Up @@ -164,7 +164,7 @@ static NotifierList kvm_irqchip_change_notifiers =

int kvm_get_max_memslots(void)
{
KVMState *s = KVM_STATE(current_machine->accelerator);
KVMState *s = KVM_STATE(current_accel());

return s->nr_slots;
}
Expand Down Expand Up @@ -1848,7 +1848,7 @@ static int kvm_max_vcpu_id(KVMState *s)

bool kvm_vcpu_id_is_valid(int vcpu_id)
{
KVMState *s = KVM_STATE(current_machine->accelerator);
KVMState *s = KVM_STATE(current_accel());
return vcpu_id >= 0 && vcpu_id < kvm_max_vcpu_id(s);
}

Expand Down
2 changes: 1 addition & 1 deletion accel/tcg/tcg-all.c
Expand Up @@ -124,7 +124,7 @@ static void tcg_accel_instance_init(Object *obj)

static int tcg_init(MachineState *ms)
{
TCGState *s = TCG_STATE(current_machine->accelerator);
TCGState *s = TCG_STATE(current_accel());

tcg_exec_init(s->tb_size * 1024 * 1024);
cpu_interrupt_handler = tcg_handle_interrupt;
Expand Down
2 changes: 1 addition & 1 deletion memory.c
Expand Up @@ -3104,7 +3104,7 @@ void mtree_info(bool flatview, bool dispatch_tree, bool owner)
};
GArray *fv_address_spaces;
GHashTable *views = g_hash_table_new(g_direct_hash, g_direct_equal);
AccelClass *ac = ACCEL_GET_CLASS(current_machine->accelerator);
AccelClass *ac = ACCEL_GET_CLASS(current_accel());

if (ac->has_memory) {
fvi.ac = ac;
Expand Down
5 changes: 2 additions & 3 deletions target/arm/kvm64.c
Expand Up @@ -26,7 +26,6 @@
#include "sysemu/kvm.h"
#include "sysemu/kvm_int.h"
#include "kvm_arm.h"
#include "hw/boards.h"
#include "internals.h"

static bool have_guest_debug;
Expand Down Expand Up @@ -613,14 +612,14 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)

bool kvm_arm_aarch32_supported(CPUState *cpu)
{
KVMState *s = KVM_STATE(current_machine->accelerator);
KVMState *s = KVM_STATE(current_accel());

return kvm_check_extension(s, KVM_CAP_ARM_EL1_32BIT);
}

bool kvm_arm_sve_supported(CPUState *cpu)
{
KVMState *s = KVM_STATE(current_machine->accelerator);
KVMState *s = KVM_STATE(current_accel());

return kvm_check_extension(s, KVM_CAP_ARM_SVE);
}
Expand Down
2 changes: 1 addition & 1 deletion target/i386/kvm.c
Expand Up @@ -149,7 +149,7 @@ bool kvm_allows_irq0_override(void)

static bool kvm_x2apic_api_set_flags(uint64_t flags)
{
KVMState *s = KVM_STATE(current_machine->accelerator);
KVMState *s = KVM_STATE(current_accel());

return !kvm_vm_enable_cap(s, KVM_CAP_X2APIC_API, 0, flags);
}
Expand Down
4 changes: 2 additions & 2 deletions target/ppc/kvm.c
Expand Up @@ -258,7 +258,7 @@ static void kvm_get_smmu_info(struct kvm_ppc_smmu_info *info, Error **errp)

struct ppc_radix_page_info *kvm_get_radix_page_info(void)
{
KVMState *s = KVM_STATE(current_machine->accelerator);
KVMState *s = KVM_STATE(current_accel());
struct ppc_radix_page_info *radix_page_info;
struct kvm_ppc_rmmu_info rmmu_info;
int i;
Expand Down Expand Up @@ -2907,7 +2907,7 @@ void kvmppc_svm_off(Error **errp)
return;
}

rc = kvm_vm_ioctl(KVM_STATE(current_machine->accelerator), KVM_PPC_SVM_OFF);
rc = kvm_vm_ioctl(KVM_STATE(current_accel()), KVM_PPC_SVM_OFF);
if (rc && rc != -ENOTTY) {
error_setg_errno(errp, -rc, "KVM_PPC_SVM_OFF ioctl failed");
}
Expand Down
2 changes: 1 addition & 1 deletion vl.c
Expand Up @@ -2824,7 +2824,7 @@ static void configure_accelerators(const char *progname)
}

if (init_failed) {
AccelClass *ac = ACCEL_GET_CLASS(current_machine->accelerator);
AccelClass *ac = ACCEL_GET_CLASS(current_accel());
error_report("falling back to %s", ac->name);
}

Expand Down

0 comments on commit 4f7f589

Please sign in to comment.