Skip to content

Commit

Permalink
sysemu: Split sysemu/runstate.h off sysemu/sysemu.h
Browse files Browse the repository at this point in the history
sysemu/sysemu.h is a rather unfocused dumping ground for stuff related
to the system-emulator.  Evidence:

* It's included widely: in my "build everything" tree, changing
  sysemu/sysemu.h still triggers a recompile of some 1100 out of 6600
  objects (not counting tests and objects that don't depend on
  qemu/osdep.h, down from 5400 due to the previous two commits).

* It pulls in more than a dozen additional headers.

Split stuff related to run state management into its own header
sysemu/runstate.h.

Touching sysemu/sysemu.h now recompiles some 850 objects.  qemu/uuid.h
also drops from 1100 to 850, and qapi/qapi-types-run-state.h from 4400
to 4200.  Touching new sysemu/runstate.h recompiles some 500 objects.

Since I'm touching MAINTAINERS to add sysemu/runstate.h anyway, also
add qemu/main-loop.h.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-30-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
[Unbreak OS-X build]
  • Loading branch information
Markus Armbruster committed Aug 16, 2019
1 parent 2f780b6 commit 54d3123
Show file tree
Hide file tree
Showing 143 changed files with 216 additions and 143 deletions.
2 changes: 2 additions & 0 deletions MAINTAINERS
Expand Up @@ -1924,6 +1924,8 @@ Main loop
M: Paolo Bonzini <pbonzini@redhat.com>
S: Maintained
F: cpus.c
F: include/qemu/main-loop.h
F: include/sysemu/runstate.h
F: util/main-loop.c
F: util/qemu-timer.c
F: vl.c
Expand Down
1 change: 1 addition & 0 deletions accel/kvm/kvm-all.c
Expand Up @@ -28,6 +28,7 @@
#include "hw/s390x/adapter.h"
#include "exec/gdbstub.h"
#include "sysemu/kvm_int.h"
#include "sysemu/runstate.h"
#include "sysemu/cpus.h"
#include "sysemu/sysemu.h"
#include "qemu/bswap.h"
Expand Down
2 changes: 1 addition & 1 deletion audio/audio.c
Expand Up @@ -30,10 +30,10 @@
#include "qapi/error.h"
#include "qapi/qobject-input-visitor.h"
#include "qapi/qapi-visit-audio.h"
#include "sysemu/sysemu.h"
#include "qemu/cutils.h"
#include "qemu/module.h"
#include "sysemu/replay.h"
#include "sysemu/runstate.h"
#include "trace.h"

#define AUDIO_CAP "audio"
Expand Down
2 changes: 1 addition & 1 deletion block/block-backend.c
Expand Up @@ -17,7 +17,7 @@
#include "block/throttle-groups.h"
#include "hw/qdev-core.h"
#include "sysemu/blockdev.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "qapi/error.h"
#include "qapi/qapi-events-block.h"
#include "qemu/id.h"
Expand Down
1 change: 1 addition & 0 deletions blockdev.c
Expand Up @@ -58,6 +58,7 @@
#include "block/trace.h"
#include "sysemu/arch_init.h"
#include "sysemu/qtest.h"
#include "sysemu/runstate.h"
#include "qemu/cutils.h"
#include "qemu/help_option.h"
#include "qemu/main-loop.h"
Expand Down
2 changes: 1 addition & 1 deletion cpus.c
Expand Up @@ -41,7 +41,6 @@
#include "sysemu/kvm.h"
#include "sysemu/hax.h"
#include "sysemu/hvf.h"
#include "sysemu/sysemu.h"
#include "sysemu/whpx.h"
#include "exec/exec-all.h"

Expand All @@ -56,6 +55,7 @@
#include "tcg.h"
#include "hw/nmi.h"
#include "sysemu/replay.h"
#include "sysemu/runstate.h"
#include "hw/boards.h"
#include "hw/hw.h"

Expand Down
2 changes: 1 addition & 1 deletion dump/dump.c
Expand Up @@ -20,8 +20,8 @@
#include "monitor/monitor.h"
#include "sysemu/kvm.h"
#include "sysemu/dump.h"
#include "sysemu/sysemu.h"
#include "sysemu/memory_mapping.h"
#include "sysemu/runstate.h"
#include "sysemu/cpus.h"
#include "qapi/error.h"
#include "qapi/qapi-commands-dump.h"
Expand Down
1 change: 1 addition & 0 deletions gdbstub.c
Expand Up @@ -48,6 +48,7 @@
#include "qemu/sockets.h"
#include "sysemu/hw_accel.h"
#include "sysemu/kvm.h"
#include "sysemu/runstate.h"
#include "hw/semihosting/semihost.h"
#include "exec/exec-all.h"

Expand Down
2 changes: 1 addition & 1 deletion hw/acpi/core.c
Expand Up @@ -20,7 +20,6 @@
*/

#include "qemu/osdep.h"
#include "sysemu/sysemu.h"
#include "hw/irq.h"
#include "hw/acpi/acpi.h"
#include "hw/nvram/fw_cfg.h"
Expand All @@ -32,6 +31,7 @@
#include "qemu/error-report.h"
#include "qemu/module.h"
#include "qemu/option.h"
#include "sysemu/runstate.h"

struct acpi_table_header {
uint16_t _length; /* our length, not actual part of the hdr */
Expand Down
2 changes: 1 addition & 1 deletion hw/acpi/ich9.c
Expand Up @@ -33,7 +33,7 @@
#include "qemu/timer.h"
#include "qom/cpu.h"
#include "sysemu/reset.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "hw/acpi/acpi.h"
#include "hw/acpi/tco.h"
#include "exec/address-spaces.h"
Expand Down
1 change: 1 addition & 0 deletions hw/acpi/piix4.c
Expand Up @@ -28,6 +28,7 @@
#include "hw/qdev-properties.h"
#include "hw/acpi/acpi.h"
#include "sysemu/reset.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "qapi/error.h"
#include "qemu/range.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/highbank.c
Expand Up @@ -26,6 +26,7 @@
#include "hw/loader.h"
#include "net/net.h"
#include "sysemu/kvm.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "hw/boards.h"
#include "exec/address-spaces.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/integratorcp.c
Expand Up @@ -18,6 +18,7 @@
#include "hw/net/smc91c111.h"
#include "net/net.h"
#include "exec/address-spaces.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "qemu/error-report.h"
#include "hw/char/pl011.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/msf2-soc.c
Expand Up @@ -30,6 +30,7 @@
#include "hw/irq.h"
#include "hw/arm/msf2-soc.h"
#include "hw/misc/unimp.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"

#define MSF2_TIMER_BASE 0x40004000
Expand Down
1 change: 1 addition & 0 deletions hw/arm/musicpal.c
Expand Up @@ -29,6 +29,7 @@
#include "hw/irq.h"
#include "hw/audio/wm8750.h"
#include "sysemu/block-backend.h"
#include "sysemu/runstate.h"
#include "exec/address-spaces.h"
#include "ui/pixel_ops.h"

Expand Down
1 change: 1 addition & 0 deletions hw/arm/nseries.c
Expand Up @@ -24,6 +24,7 @@
#include "qemu/cutils.h"
#include "qemu/bswap.h"
#include "sysemu/reset.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "hw/arm/omap.h"
#include "hw/arm/boot.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/omap1.c
Expand Up @@ -34,6 +34,7 @@
#include "hw/arm/soc_dma.h"
#include "sysemu/qtest.h"
#include "sysemu/reset.h"
#include "sysemu/runstate.h"
#include "qemu/range.h"
#include "hw/sysbus.h"
#include "qemu/cutils.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/omap2.c
Expand Up @@ -25,6 +25,7 @@
#include "sysemu/blockdev.h"
#include "sysemu/qtest.h"
#include "sysemu/reset.h"
#include "sysemu/runstate.h"
#include "hw/boards.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/sbsa-ref.c
Expand Up @@ -24,6 +24,7 @@
#include "qemu/units.h"
#include "sysemu/device_tree.h"
#include "sysemu/numa.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "exec/address-spaces.h"
#include "exec/hwaddr.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/spitz.c
Expand Up @@ -14,6 +14,7 @@
#include "qapi/error.h"
#include "hw/arm/pxa.h"
#include "hw/arm/boot.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "hw/pcmcia.h"
#include "hw/qdev-properties.h"
Expand Down
1 change: 1 addition & 0 deletions hw/arm/stellaris.c
Expand Up @@ -18,6 +18,7 @@
#include "hw/boards.h"
#include "qemu/log.h"
#include "exec/address-spaces.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "hw/arm/armv7m.h"
#include "hw/char/pl011.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/arm/tosa.c
Expand Up @@ -13,6 +13,7 @@

#include "qemu/osdep.h"
#include "qapi/error.h"
#include "sysemu/runstate.h"
#include "hw/arm/pxa.h"
#include "hw/arm/boot.h"
#include "hw/arm/sharpsl.h"
Expand All @@ -24,7 +25,6 @@
#include "hw/ssi/ssi.h"
#include "hw/sysbus.h"
#include "exec/address-spaces.h"
#include "sysemu/sysemu.h"

#define TOSA_RAM 0x04000000
#define TOSA_ROM 0x00800000
Expand Down
1 change: 1 addition & 0 deletions hw/arm/virt.c
Expand Up @@ -45,6 +45,7 @@
#include "net/net.h"
#include "sysemu/device_tree.h"
#include "sysemu/numa.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "sysemu/kvm.h"
#include "hw/loader.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/block/pflash_cfi01.c
Expand Up @@ -52,7 +52,7 @@
#include "hw/sysbus.h"
#include "migration/vmstate.h"
#include "sysemu/blockdev.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "trace.h"

/* #define PFLASH_DEBUG */
Expand Down
1 change: 1 addition & 0 deletions hw/block/vhost-user-blk.c
Expand Up @@ -29,6 +29,7 @@
#include "hw/virtio/virtio-bus.h"
#include "hw/virtio/virtio-access.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"

static const int user_feature_bits[] = {
VIRTIO_BLK_F_SIZE_MAX,
Expand Down
1 change: 1 addition & 0 deletions hw/block/virtio-blk.c
Expand Up @@ -21,6 +21,7 @@
#include "hw/qdev-properties.h"
#include "sysemu/blockdev.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "hw/virtio/virtio-blk.h"
#include "dataplane/virtio-blk.h"
#include "scsi/constants.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/char/serial.c
Expand Up @@ -31,7 +31,7 @@
#include "qapi/error.h"
#include "qemu/timer.h"
#include "sysemu/reset.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "qemu/error-report.h"
#include "trace.h"

Expand Down
1 change: 1 addition & 0 deletions hw/core/machine-qmp-cmds.c
Expand Up @@ -17,6 +17,7 @@
#include "sysemu/hostmem.h"
#include "sysemu/hw_accel.h"
#include "sysemu/numa.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"

CpuInfoList *qmp_query_cpus(Error **errp)
Expand Down
2 changes: 1 addition & 1 deletion hw/core/vm-change-state-handler.c
Expand Up @@ -17,7 +17,7 @@

#include "qemu/osdep.h"
#include "hw/qdev-core.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"

static int qdev_get_dev_tree_depth(DeviceState *dev)
{
Expand Down
2 changes: 1 addition & 1 deletion hw/display/qxl-render.c
Expand Up @@ -21,7 +21,7 @@

#include "qemu/osdep.h"
#include "qxl.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "trace.h"

static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect)
Expand Down
2 changes: 1 addition & 1 deletion hw/display/qxl.c
Expand Up @@ -28,8 +28,8 @@
#include "qemu/atomic.h"
#include "qemu/main-loop.h"
#include "qemu/module.h"
#include "sysemu/sysemu.h"
#include "hw/qdev-properties.h"
#include "sysemu/runstate.h"
#include "migration/blocker.h"
#include "migration/vmstate.h"
#include "trace.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/dma/etraxfs_dma.c
Expand Up @@ -26,8 +26,8 @@
#include "hw/hw.h"
#include "hw/irq.h"
#include "qemu/main-loop.h"
#include "sysemu/runstate.h"
#include "exec/address-spaces.h"
#include "sysemu/sysemu.h"

#include "hw/cris/etraxfs_dma.h"

Expand Down
2 changes: 1 addition & 1 deletion hw/i386/kvm/clock.c
Expand Up @@ -17,8 +17,8 @@
#include "cpu.h"
#include "qemu/host-utils.h"
#include "qemu/module.h"
#include "sysemu/sysemu.h"
#include "sysemu/kvm.h"
#include "sysemu/runstate.h"
#include "sysemu/hw_accel.h"
#include "kvm_i386.h"
#include "migration/vmstate.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/i386/kvm/i8254.c
Expand Up @@ -29,7 +29,7 @@
#include "qapi/error.h"
#include "qemu/module.h"
#include "qemu/timer.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "hw/timer/i8254.h"
#include "hw/timer/i8254_internal.h"
#include "sysemu/kvm.h"
Expand Down
1 change: 1 addition & 0 deletions hw/i386/kvmvapic.c
Expand Up @@ -16,6 +16,7 @@
#include "sysemu/cpus.h"
#include "sysemu/hw_accel.h"
#include "sysemu/kvm.h"
#include "sysemu/runstate.h"
#include "hw/i386/apic_internal.h"
#include "hw/sysbus.h"
#include "hw/boards.h"
Expand Down
1 change: 1 addition & 0 deletions hw/i386/pc.c
Expand Up @@ -56,6 +56,7 @@
#include "sysemu/kvm.h"
#include "sysemu/qtest.h"
#include "sysemu/reset.h"
#include "sysemu/runstate.h"
#include "kvm_i386.h"
#include "hw/xen/xen.h"
#include "hw/xen/start_info.h"
Expand Down
1 change: 1 addition & 0 deletions hw/i386/xen/xen-hvm.c
Expand Up @@ -25,6 +25,7 @@
#include "qemu/error-report.h"
#include "qemu/main-loop.h"
#include "qemu/range.h"
#include "sysemu/runstate.h"
#include "sysemu/sysemu.h"
#include "sysemu/xen-mapcache.h"
#include "trace.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/i386/xen/xen-mapcache.c
Expand Up @@ -17,7 +17,7 @@
#include "hw/xen/xen-legacy-backend.h"
#include "qemu/bitmap.h"

#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "sysemu/xen-mapcache.h"
#include "trace.h"

Expand Down
2 changes: 1 addition & 1 deletion hw/ide/core.c
Expand Up @@ -37,7 +37,7 @@
#include "qapi/error.h"
#include "qemu/cutils.h"
#include "sysemu/replay.h"

#include "sysemu/runstate.h"
#include "hw/ide/internal.h"
#include "trace.h"

Expand Down
1 change: 1 addition & 0 deletions hw/ide/qdev.c
Expand Up @@ -30,6 +30,7 @@
#include "sysemu/blockdev.h"
#include "hw/block/block.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "qapi/visitor.h"

/* --------------------------------- */
Expand Down
2 changes: 1 addition & 1 deletion hw/input/pckbd.c
Expand Up @@ -31,7 +31,7 @@
#include "hw/irq.h"
#include "hw/input/i8042.h"
#include "sysemu/reset.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"

#include "trace.h"

Expand Down
2 changes: 1 addition & 1 deletion hw/input/ps2.c
Expand Up @@ -29,7 +29,7 @@
#include "ui/console.h"
#include "ui/input.h"
#include "sysemu/reset.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"

#include "trace.h"

Expand Down
2 changes: 1 addition & 1 deletion hw/intc/arm_gicv3_its_kvm.c
Expand Up @@ -23,7 +23,7 @@
#include "qemu/module.h"
#include "hw/intc/arm_gicv3_its_common.h"
#include "hw/qdev-properties.h"
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
#include "sysemu/kvm.h"
#include "kvm_arm.h"
#include "migration/blocker.h"
Expand Down

0 comments on commit 54d3123

Please sign in to comment.