Skip to content

Commit

Permalink
softmmu/physmem: Simplify flatview_write and address_space_access_valid
Browse files Browse the repository at this point in the history
Remove unuseful local 'result' variables.

Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211215182421.418374-3-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
philmd authored and huth committed Mar 21, 2022
1 parent 2058fdb commit 58e7468
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions softmmu/physmem.c
Expand Up @@ -2816,14 +2816,11 @@ static MemTxResult flatview_write(FlatView *fv, hwaddr addr, MemTxAttrs attrs,
hwaddr l;
hwaddr addr1;
MemoryRegion *mr;
MemTxResult result = MEMTX_OK;

l = len;
mr = flatview_translate(fv, addr, &addr1, &l, true, attrs);
result = flatview_write_continue(fv, addr, attrs, buf, len,
addr1, l, mr);

return result;
return flatview_write_continue(fv, addr, attrs, buf, len,
addr1, l, mr);
}

/* Called within RCU critical section. */
Expand Down Expand Up @@ -3139,12 +3136,10 @@ bool address_space_access_valid(AddressSpace *as, hwaddr addr,
MemTxAttrs attrs)
{
FlatView *fv;
bool result;

RCU_READ_LOCK_GUARD();
fv = address_space_to_flatview(as);
result = flatview_access_valid(fv, addr, len, is_write, attrs);
return result;
return flatview_access_valid(fv, addr, len, is_write, attrs);
}

static hwaddr
Expand Down

0 comments on commit 58e7468

Please sign in to comment.