Skip to content

Commit

Permalink
char: remove unused qemu_chr_fe_event
Browse files Browse the repository at this point in the history
I introduced this function in d61b0c9, but it isn't
used. Furthermore, it was incomplete, as it would need to translate QEMU
chr events to Spice port events.

(presumably it was used in the follow-up NBD-spice series that was not
completed: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02024.html)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20161022100951.19562-4-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
elmarco authored and bonzini committed Oct 24, 2016
1 parent 8c260cb commit 58fa549
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 30 deletions.
11 changes: 0 additions & 11 deletions include/sysemu/char.h
Expand Up @@ -103,7 +103,6 @@ struct CharDriverState {
void (*chr_accept_input)(struct CharDriverState *chr);
void (*chr_set_echo)(struct CharDriverState *chr, bool echo);
void (*chr_set_fe_open)(struct CharDriverState *chr, int fe_open);
void (*chr_fe_event)(struct CharDriverState *chr, int event);
CharBackend *be;
void *opaque;
char *label;
Expand Down Expand Up @@ -238,16 +237,6 @@ void qemu_chr_fe_set_echo(CharBackend *be, bool echo);
*/
void qemu_chr_fe_set_open(CharBackend *be, int fe_open);

/**
* @qemu_chr_fe_event:
*
* Send an event from the front end to the back end. It does nothing
* without associated CharDriver.
*
* @event the event to send
*/
void qemu_chr_fe_event(CharBackend *be, int event);

/**
* @qemu_chr_fe_printf:
*
Expand Down
9 changes: 0 additions & 9 deletions qemu-char.c
Expand Up @@ -4226,15 +4226,6 @@ void qemu_chr_fe_set_open(CharBackend *be, int fe_open)
}
}

void qemu_chr_fe_event(CharBackend *be, int event)
{
CharDriverState *chr = be->chr;

if (chr && chr->chr_fe_event) {
chr->chr_fe_event(chr, event);
}
}

guint qemu_chr_fe_add_watch(CharBackend *be, GIOCondition cond,
GIOFunc func, void *user_data)
{
Expand Down
10 changes: 0 additions & 10 deletions spice-qemu-char.c
Expand Up @@ -236,15 +236,6 @@ static void spice_port_set_fe_open(struct CharDriverState *chr, int fe_open)
#endif
}

static void spice_chr_fe_event(struct CharDriverState *chr, int event)
{
#if SPICE_SERVER_VERSION >= 0x000c02
SpiceCharDriver *s = chr->opaque;

spice_server_port_event(&s->sin, event);
#endif
}

static void print_allowed_subtypes(void)
{
const char** psubtype;
Expand Down Expand Up @@ -292,7 +283,6 @@ static CharDriverState *chr_open(const char *subtype,
chr->chr_free = spice_chr_free;
chr->chr_set_fe_open = set_fe_open;
chr->explicit_be_open = true;
chr->chr_fe_event = spice_chr_fe_event;
chr->chr_accept_input = spice_chr_accept_input;

QLIST_INSERT_HEAD(&spice_chars, s, next);
Expand Down

0 comments on commit 58fa549

Please sign in to comment.