Skip to content

Commit

Permalink
tests/qtest/readconfig-test: Allow testing for arbitrary memory sizes
Browse files Browse the repository at this point in the history
Make test_x86_memdev_resp() more flexible by allowing arbitrary
memory sizes as parameter here.

Message-Id: <20230704071655.75381-2-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
huth committed Jul 10, 2023
1 parent bfde1be commit 5a7d4dc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/qtest/readconfig-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static QTestState *qtest_init_with_config(const char *cfgdata)
return qts;
}

static void test_x86_memdev_resp(QObject *res)
static void test_x86_memdev_resp(QObject *res, const char *mem_id, int size)
{
Visitor *v;
g_autoptr(MemdevList) memdevs = NULL;
Expand All @@ -63,8 +63,8 @@ static void test_x86_memdev_resp(QObject *res)
g_assert(!memdevs->next);

memdev = memdevs->value;
g_assert_cmpstr(memdev->id, ==, "ram");
g_assert_cmpint(memdev->size, ==, 200 * MiB);
g_assert_cmpstr(memdev->id, ==, mem_id);
g_assert_cmpint(memdev->size, ==, size * MiB);

visit_free(v);
}
Expand All @@ -80,7 +80,7 @@ static void test_x86_memdev(void)
qts = qtest_init_with_config(cfgdata);
/* Test valid command */
resp = qtest_qmp(qts, "{ 'execute': 'query-memdev' }");
test_x86_memdev_resp(qdict_get(resp, "return"));
test_x86_memdev_resp(qdict_get(resp, "return"), "ram", 200);
qobject_unref(resp);

qtest_quit(qts);
Expand Down

0 comments on commit 5a7d4dc

Please sign in to comment.