Skip to content

Commit

Permalink
qobject: Clean up QLIST_FOREACH_ENTRY()
Browse files Browse the repository at this point in the history
QLIST_FOREACH_ENTRY() traverses a tail queue manually.  Use
QTAILQ_FIRST() and QTAILQ_NEXT() instead.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200415083048.14339-2-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
  • Loading branch information
Markus Armbruster committed Apr 30, 2020
1 parent 648db19 commit 64594e2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions include/qapi/qmp/qlist.h
Expand Up @@ -34,10 +34,10 @@ void qlist_append_int(QList *qlist, int64_t value);
void qlist_append_null(QList *qlist);
void qlist_append_str(QList *qlist, const char *value);

#define QLIST_FOREACH_ENTRY(qlist, var) \
for ((var) = ((qlist)->head.tqh_first); \
(var); \
(var) = ((var)->next.tqe_next))
#define QLIST_FOREACH_ENTRY(qlist, var) \
for ((var) = QTAILQ_FIRST(&(qlist)->head); \
(var); \
(var) = QTAILQ_NEXT((var), next))

static inline QObject *qlist_entry_obj(const QListEntry *entry)
{
Expand Down

0 comments on commit 64594e2

Please sign in to comment.