Skip to content

Commit

Permalink
fpu/softfloat: Fix conversion from uint64 to float128
Browse files Browse the repository at this point in the history
The significand is passed to normalizeRoundAndPackFloat128() as high
first, low second. The current code passes the integer first, so the
result is incorrectly shifted left by 64 bits.

This bug affects the emulation of s390x instruction CXLGBR (convert
from logical 64-bit binary-integer operand to extended BFP result).

Cc: qemu-stable@nongnu.org
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
Message-Id: <20180511071052.1443-1-ptesarik@suse.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
  • Loading branch information
ptesarik authored and rth7680 committed May 17, 2018
1 parent a4207e3 commit 6603d50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fpu/softfloat.c
Expand Up @@ -3147,7 +3147,7 @@ float128 uint64_to_float128(uint64_t a, float_status *status)
if (a == 0) {
return float128_zero;
}
return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status);
return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status);
}


Expand Down

0 comments on commit 6603d50

Please sign in to comment.